Added the version attribute to the artifact data model#84
Merged
Conversation
jstlaurent
approved these changes
Mar 27, 2024
jstlaurent
left a comment
Contributor
There was a problem hiding this comment.
Good idea. We'll probably like having that info at some point in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelogs
versionattribute to theBaseArtifactModel.Checklist:
Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.feature,fixortest(or ask a maintainer to do it for you).If we ever want to change a function that would break backwards compatibility, we now have the opportunity to maintain backwards compatibility by adding conditional logic based on the version. Not saying this should be our preferred approach, but I think it's nevertheless good to have the opportunity.