Skip to content

Updating dataset upload to respect Dataset name#159

Merged
Andrewq11 merged 4 commits into
mainfrom
fix/benchmark-naming
Jul 26, 2024
Merged

Updating dataset upload to respect Dataset name#159
Andrewq11 merged 4 commits into
mainfrom
fix/benchmark-naming

Conversation

@Andrewq11

@Andrewq11 Andrewq11 commented Jul 26, 2024

Copy link
Copy Markdown
Contributor

Changelogs

  • Updated client.upload_benchmark method to use the correct, sluggified owner/name combination during benchmark upload.

  • Currently, dataset uploads are completed such that the name of the dataset is really the slug. These two differ in that slugs convert underscores to hyphens whereas names do not. Because the name and slug are separate things, and the name of the dataset should be the name (not the slug), this change ensures that user naming is respected on dataset upload.


Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).
  • Update the API documentation if a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix, chore, documentation or test (or ask a maintainer to do it for you).

discussion related to that PR

@Andrewq11 Andrewq11 added the fix Annotates any PR that fixes bugs label Jul 26, 2024
@Andrewq11 Andrewq11 self-assigned this Jul 26, 2024
@Andrewq11 Andrewq11 requested a review from cwognum as a code owner July 26, 2024 15:21
@Andrewq11 Andrewq11 changed the title Ensuring benchmark name is sluggified on upload Updating dataset upload to respect Dataset name Jul 26, 2024
@Andrewq11 Andrewq11 merged commit e71bd79 into main Jul 26, 2024
@cwognum cwognum deleted the fix/benchmark-naming branch August 9, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Annotates any PR that fixes bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants