Type the return type of @model_validator(mode="after") with Self#198
Merged
Conversation
@model_validator(mode="after") with Self
Collaborator
Author
|
Sorry for not waiting for your response @jstlaurent ! Quickly opened this PR to still address the feedback! 😄 |
Andrewq11
approved these changes
Sep 13, 2024
jstlaurent
approved these changes
Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelogs
@model_validator(mode="after")withSelfChecklist:
Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).Update the API documentation if a new function is added, or an existing one is deleted.feature,fix,chore,documentationortest(or ask a maintainer to do it for you).This came up in #186 , but I only saw it after merging. See #186 (comment) .