Skip to content

fix: Allow extra settings in the .env file#216

Merged
jstlaurent merged 1 commit into
mainfrom
fix/extra-settings
Nov 11, 2024
Merged

fix: Allow extra settings in the .env file#216
jstlaurent merged 1 commit into
mainfrom
fix/extra-settings

Conversation

@jstlaurent

@jstlaurent jstlaurent commented Nov 11, 2024

Copy link
Copy Markdown
Contributor

Changelogs

  • Allow extra settings in the .env file without raising an error

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • [ ] Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).
  • [ ] Update the API documentation if a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix, chore, documentation or test (or ask a maintainer to do it for you).

Issues

@jstlaurent jstlaurent requested a review from cwognum as a code owner November 11, 2024 01:53
@jstlaurent jstlaurent added the fix Annotates any PR that fixes bugs label Nov 11, 2024
@jstlaurent jstlaurent self-assigned this Nov 11, 2024

@cwognum cwognum left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jstlaurent !

@jstlaurent jstlaurent merged commit 225b405 into main Nov 11, 2024
@jstlaurent jstlaurent deleted the fix/extra-settings branch November 11, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Annotates any PR that fixes bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PolarisHubSettings does not play well with other .env files

3 participants