Add custom codecs for RDKit Molecules and Biotite AtomArrays#243
Merged
Conversation
jstlaurent
approved these changes
Jan 10, 2025
Co-authored-by: Julien St-Laurent <jstlaurent@users.noreply.github.com>
Andrewq11
approved these changes
Jan 10, 2025
Andrewq11
left a comment
Contributor
There was a problem hiding this comment.
I'm glad we went down that rabbit hole and figured this out. Kudos to you and @jstlaurent!
Just left a single comment but it looks good to me 🚀
This was referenced Jan 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelogs
Checklist:
Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).feature,fix,chore,documentationortest(or ask a maintainer to do it for you).This PR builds on the discussion in #241.
The use of custom
numcodecs-compatible object codecs for use in Zarr seems like a natural interface point to document and implement conversion from and to drug discovery specific format.You would simply use this like: