chore: Update skip condition for integration tests#260
Conversation
cwognum
left a comment
There was a problem hiding this comment.
Thanks @jstlaurent ! I'm surprised that this has been working locally but now fails in the CICD. Is this needed because os.getenv() returns an empty string rather than None for PRs opened by external contributors? To predict our CICD secrets, presumably?
4a325a7 to
09dca52
Compare
Yep. When a PR comes from a fork, the secrets are present as environment variables, but they contain an empty string. Why GitHub chose this, I honestly don't understand... When using I updated the Pydantic settings class to If we need to expose secrets to external contributors, we can create deployment environments and invite folks there. That way, we can control who gets access. I don't think we need this right now, but it's an option for the future. |
Changelogs
Checklist:
Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).Update the API documentation if a new function is added, or an existing one is deleted.feature,fix,chore,documentationortest(or ask a maintainer to do it for you).The previous check would pass if at least one of username or password was set, and the test would fail.