Fix: UnicodeEncodeError on Windows due to emoji use#264
Merged
Conversation
Expect this to fail on Windows
Collaborator
Author
|
Hmm... I was expecting the new test case to fail for Windows. Let's see if I can reproduce the error in our CICD. |
agitter
approved these changes
Feb 2, 2025
agitter
left a comment
There was a problem hiding this comment.
This fixes my issue #263. I tested on the same machine with
pip install -U git+https://github.com/polaris-hub/polaris.git@2737b66c72d7daf67ee7e2062d2c0316c611efe7
and now get
$ polaris login
[2025-02-02 17:32:29] INFO You are successfully logged in to client.py:252
the Polaris Hub.
I'm not sure why the tests here didn't reproduce the problem. I'm on Windows 10, which could be a difference. Other system information from conda info that could point to environment differences
user-agent : conda/23.1.0 requests/2.31.0 CPython/3.9.18 Windows/10 Windows/10.0.19045 solver/libmamba conda-libmamba-solver/22.8.1 libmambapy/1.3.1 aau/0.4.3 c/MJFdvaQxP8tx_bXR_Hb8eg s/fa04h50TeXGA8K05bh0tNQ e/UibNJO7p5_nb6vlS3wqlrA
but it doesn't matter because the problem is resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelogs
Checklist:
feature,fix,chore,documentationortest(or ask a maintainer to do it for you).Fixes #263