feat: Support for Model artifacts#265
Merged
Merged
Conversation
cwognum
approved these changes
Feb 3, 2025
cwognum
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @mercuryseries ! 🙏
Collaborator
|
@mercuryseries For the failing test case, looks like you were just unlucky! We should set the random seed for that test case so that doesn't happen again. |
jstlaurent
reviewed
Feb 3, 2025
jstlaurent
left a comment
Contributor
There was a problem hiding this comment.
Short and sweet. Very nice. 😄
I do agree with Cas' comment, about making this only available on Results V2, for Benchmark V2s.
dded7f3 to
ec89949
Compare
ec89949 to
f9dcd30
Compare
cwognum
approved these changes
Feb 11, 2025
cwognum
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Thanks @mercuryseries ! Nice job on splitting it in a V1 and V2.
Co-authored-by: Cas Wognum <cwognum@users.noreply.github.com>
70d973a to
bcbf275
Compare
Andrewq11
approved these changes
Feb 11, 2025
Andrewq11
left a comment
Contributor
There was a problem hiding this comment.
Really nice @mercuryseries, thanks for this! 🚀
Left a few minor comments but LGTM overall.
Co-authored-by: Andrew Quirke <Andrewq11@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelogs
Modelclass to represent a model artifact.load_modelutility function to load a model.Checklist:
feature,fix,chore,documentationortest(or ask a maintainer to do it for you).TODO