Skip to content

feat: Model Versioning#284

Merged
roselynh100 merged 4 commits into
mainfrom
feat/model-versioning
Apr 21, 2025
Merged

feat: Model Versioning#284
roselynh100 merged 4 commits into
mainfrom
feat/model-versioning

Conversation

@roselynh100

@roselynh100 roselynh100 commented Apr 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

🗝️ Hub changes here!

Changelogs

  • Added artifact_version and artifact_version fields to model artifact
  • Modified upload_to_hub and upload_model functions to accept parent_artifact_id, in order to upload a new version of a model
  • Updated tutorial to explain how to upload a new version of a model

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).
  • Update the API documentation if a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix, chore, documentation or test (or ask a maintainer to do it for you).

@roselynh100 roselynh100 marked this pull request as ready for review April 17, 2025 19:24
@roselynh100 roselynh100 requested a review from cwognum as a code owner April 17, 2025 19:24
@roselynh100 roselynh100 added the feature Annotates any PR that adds new features; Used in the release process label Apr 17, 2025
@roselynh100 roselynh100 self-assigned this Apr 17, 2025
cwognum
cwognum approved these changes Apr 17, 2025
View reviewed changes

@cwognum cwognum left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @roselynh100 !

Andrewq11
Andrewq11 approved these changes Apr 21, 2025
View reviewed changes

@Andrewq11 Andrewq11 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, @roselynh100! I left one comment that would apply to the other versioned artifacts as well. Great work 🚀

Comment thread polaris/model/__init__.py Outdated
@roselynh100 roselynh100 merged commit 4d345ac into main Apr 21, 2025
@jstlaurent jstlaurent deleted the feat/model-versioning branch May 16, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cwognum cwognum cwognum approved these changes

@Andrewq11 Andrewq11 Andrewq11 approved these changes

@jstlaurent jstlaurent Awaiting requested review from jstlaurent

@mercuryseries mercuryseries Awaiting requested review from mercuryseries

Assignees

@roselynh100 roselynh100

Labels

feature Annotates any PR that adds new features; Used in the release process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roselynh100 @cwognum @Andrewq11