Forward admin users merge #677
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p and modified so admins can use it too.
As was done at .../public/user/vacation.php and .../public/vacation.php
.../public/users/edit-forward.php added.
This provides a reference to .../public/edit-forward.php.
.../public/edit-forward.php uses .../templates/edit-forward.tpl as template this was .../templates/edit-alias.tpl
This allows .../public/user/edit-alias.php and .../templates/edit-alias.tpl to be dropped
Made changes in .../templates/list-virtual_mailbos.tpl , .../templates/user_menu.tpl and .../config/menu.conf so that they now cause .../public/edit-forward .php is called for both users and admins.
TODO
.../public/edit-forward.php to use templates/editform.tpl at David Goodwin's request to reduce the number of templates.
…p and modified so admins can use it too.
As was done at .../public/user/vacation.php and .../public/vacation.php
.../public/users/edit-forward.php added.
This provides a reference to .../public/edit-forward.php.
.../public/edit-forward.php uses .../templates/edit-forward.tpl as template this was .../templates/edit-alias.tpl
This allows .../public/user/edit-alias.php and .../templates/edit-alias.tpl to be dropped
Made changes in .../templates/list-virtual_mailbos.tpl , .../templates/user_menu.tpl and .../config/menu.conf so that they now cause .../public/edit-forward .php is called for both users and admins.
TODO
.../public/edit-forward.php to use templates/editform.tpl at David Goodwin's request to reduce the number of templates.
DavidGoodwin
reviewed
Nov 4, 2022
DavidGoodwin
reviewed
Nov 4, 2022
|
david , there is more wrong, the correct template is not called |
modification made in /templates/user_main.tpl ... replace edit-alias with edit-forward and replace PALANG.pUsersMenu_edit_alias with PALANG.pUsersMenu_edit_forward and removed or renamed /templates/users_edit-alias.tpl /public/users/edit-alias.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.../public/users/edit-alias.php renamed to .../public/edit-forward.php and modified so admins can use it too.
As was done at .../public/user/vacation.php and .../public/vacation.php
.../public/users/edit-forward.php added.
This provides a reference to .../public/edit-forward.php.
.../public/edit-forward.php uses .../templates/edit-forward.tpl as template this was .../templates/edit-alias.tpl
This allows .../public/user/edit-alias.php and .../templates/edit-alias.tpl to be dropped
Made changes in .../templates/list-virtual_mailbos.tpl , .../templates/user_menu.tpl and .../config/menu.conf so that they now cause .../public/edit-forward .php is called for both users and admins.
TODO
.../public/edit-forward.php to use templates/editform.tpl at David Goodwin's request to reduce the number of templates.