Update FlushTimer and flush_interval related code to support sub-second flushing of sinks. #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd flushing of sinks.
d2de408 to
fe5637c
Compare
Codecov Report
@@ Coverage Diff @@
## master #449 +/- ##
==========================================
+ Coverage 91.94% 92.13% +0.18%
==========================================
Files 29 30 +1
Lines 4037 4041 +4
==========================================
+ Hits 3712 3723 +11
+ Misses 325 318 -7 |
Collaborator
|
Looking through now.
- blt
On Tue, Aug 14, 2018, at 7:39 AM, John Koenig wrote:
***@***.**** approved this pull request.
LGTM.
@blt[1] Any objections?
— You are receiving this because you were mentioned. Reply to this
email directly, view it on GitHub[2], or mute the thread[3].
|
blt
reviewed
Aug 14, 2018
| ProgrammableFilterConfig, | ||
| }; | ||
| use sink::wavefront::PadControl; | ||
| use source::{StatsdConfig, StatsdParseConfig}; |
blt
approved these changes
Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a flushes_per_second() public function, accessible through the source module. This PR increases the flush frequency from 1hz to 100hz. Old configuration files remain backwards compatible. The new code will continue to accept flush_interval values that are integers, but will also now accept floating point values in order to specify sub-second flush intervals. At 100hz, the lowest delay is 10ms.