Skip to content

Implement legacy break overlay#37680

Draft
curoviyxru wants to merge 10 commits into
ppy:masterfrom
curoviyxru:legacy-break-overlay
Draft

Implement legacy break overlay#37680
curoviyxru wants to merge 10 commits into
ppy:masterfrom
curoviyxru:legacy-break-overlay

Conversation

@curoviyxru
Copy link
Copy Markdown
Contributor

Spent 2 days trying to fix rewinding with sequences. Well... I'm open to hear how to implement it in a "less hacky way".

Also is it fine that Argon and Triangles will just play section pass/fail sound?

Demo

Demo features legacy break overlay with IJN Yamashiro V2, Classic, Retro and Argon skins.

output.mp4

curoviyxru added 2 commits May 8, 2026 21:28
I wonder why it's fine in `TestSceneBreakTracker`...
@unststable
Copy link
Copy Markdown

unststable commented May 8, 2026

please take a look that stable sprite (section pass / fail) is flashing a bit faster:

2026-05-08.22-37-46.mp4

(just leaving it there as it slightly differs from the old client)

@curoviyxru
Copy link
Copy Markdown
Contributor Author

Yeah, I hope devs that have access to stable sources can help with tweaking timings in LegacyBreakOverlay.

@unststable
Copy link
Copy Markdown

unststable commented May 8, 2026

anddd one more thing: stable hides the HP bar and combo with moving and doing transparency. it's the last touch needed to match stable, after tweaking timings.

2026-05-08.23-37-29.mp4

idk how stable decides to show/not show grade on breaks, peppy better knows

@curoviyxru
Copy link
Copy Markdown
Contributor Author

curoviyxru commented May 8, 2026

Is it worth implementing? If yes, I think this stable's health bar and rank display behavior should apply only if skin is not modified in lazer's editor.

Hmm... but what if you want to customize your skin without losing this behavior... Probably this should be customizable with some "break layer" then or with additional options in settings for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants