Add slider velocity control to toolbox#37746
Open
bdach wants to merge 1 commit into
Open
Conversation
This implements a rather opinionated UX that's designed to be a middle ground between the previous lazer behaviour of unconditionally inheriting the last slider's velocity and just a textbox that you'd need to manually fiddle with every time. As to what that means, precisely: - By default, the control follows the last slider's velocity (updates on seeks as well as changes to existing objects). - When the slider control in the toolbox is manually adjusted, the control decouples from the last slider's velocity and instead uses the last manually-specified value. - There is a button that allows the user to couple back to the last slider's velocity if they consider to have made a mistake in adjusting it. - Upon successful placement of a slider, the control reverts to following the last slider's velocity. Of note, this control *only interacts with and affects the next placed slider*. It is in no way coupled to any selected objects. This may be confusing to users but was an intentional choice to limit complexity (what if there are multiple selected objects with multiple velocities?) For adjusting existing objects you can use the green pieces on the timeline, which notably do support changing multiple selected objects at once. --- - Closes ppy#36844 - Supersedes / closes ppy#33707
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-05-14.at.12.01.20.mov
This implements a rather opinionated UX that's designed to be a middle ground between the previous lazer behaviour of unconditionally inheriting the last slider's velocity and just a textbox that you'd need to manually fiddle with every time.
As to what that means, precisely:
Of note, this control only interacts with and affects the next placed slider. It is in no way coupled to any selected objects. This may be confusing to users but was an intentional choice to limit complexity (what if there are multiple selected objects with multiple velocities?)
For adjusting existing objects you can use the green pieces on the timeline, which notably do support changing multiple selected objects at once.