Ledger UI: Onboarding #402
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d7950a to
17c7160
Compare
d588630 to
272504f
Compare
59bf256 to
90d6ca5
Compare
TalDerei
approved these changes
Aug 28, 2025
Contributor
TalDerei
left a comment
There was a problem hiding this comment.
I think the onboarding UI changes are more extensive than necessary. The helper slices could have largely remained intact, but this PR opts for a unified restructuring, folding those helper slices into a single consolidated onboarding slice. I won't block on this for the interest of time.
| setPhraseLength: (phraseLength: 12 | 24) => { | ||
| const { phrase: existingPhrase } = get().onboarding.importPhrase; | ||
|
|
||
| const phrase = new Array<string>(phraseLength).map((_, i) => existingPhrase[i] ?? ''); |
Contributor
There was a problem hiding this comment.
comment: this is safer
const phrase = Array.from({ length: phraseLength }, (_, i) => existingPhrase[i] ?? '');can we make this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the user interface and onboarding flow for Ledger hardware wallet support. Building on the foundation custody infrastructure, this adds the UI components and onboarding flows. Note: This PR has been split - authorization slice changes have been moved to PR #403.
Key Changes
apps/extension/src/routes/page/onboarding/custody/connect-ledger.tsx:39-88Onboarding