Skip to content

Upgrade OpenFOAM to v2206#46

Merged
MakisH merged 5 commits into
developfrom
openfoam-v2206
Nov 18, 2022
Merged

Upgrade OpenFOAM to v2206#46
MakisH merged 5 commits into
developfrom
openfoam-v2206

Conversation

@MakisH

@MakisH MakisH commented Sep 19, 2022

Copy link
Copy Markdown
Member

Still on Ubuntu 20.04.
After the build succeeds, we still need to replace the swak4Foam compilation step with pre-built binaries, to save space and time.

@MakisH MakisH marked this pull request as ready for review September 19, 2022 06:09
@MakisH MakisH marked this pull request as draft September 19, 2022 07:02
@MakisH MakisH marked this pull request as ready for review September 19, 2022 07:02
@MakisH

MakisH commented Sep 19, 2022

Copy link
Copy Markdown
Member Author

Mainly for future reference:

this job succeeded, but with swak4Foam again falsely continuing as if it was successful, with the following error:

2022-09-19T08:46:42.8514130Z     default: wmake funkyPythonPostproc
2022-09-19T08:46:43.0270540Z     default: Making dependency list for source file funkyPythonPostproc.C
2022-09-19T08:46:43.0921460Z     default: wmkdepend: could not open 'pythonInterpreterWrapper.H' for source file 'funkyPythonPostproc.C': No such file or directory
2022-09-19T08:46:43.1253340Z     default: g++ -std=c++14 -m64 -pthread -DOPENFOAM=2206 -DWM_DP -DWM_LABEL_SIZE=32 -Wall -Wextra -Wold-style-cast -Wnon-virtual-dtor -Wno-unused-parameter -Wno-invalid-offsetof -Wno-attributes -Wno-unknown-pragmas -O3  -DNoRepository -ftemplate-depth-100  -IMake/linux64GccDPInt32Opt  	  -I/usr/lib/openfoam/openfoam2206/src/finiteVolume/lnInclude -I/usr/lib/openfoam/openfoam2206/src/sampling/lnInclude -I/usr/lib/openfoam/openfoam2206/src/meshTools/lnInclude -Wno-old-style-cast -Wno-deprecated-register -I../../Libraries/languageIntegration/swakPythonIntegration/lnInclude/ -I../../Libraries/languageIntegration/swakGeneralLanguageIntegration/lnInclude/ -I../../Libraries/simpleFunctionObjects/lnInclude/ -I../../Libraries/swak4FoamParsers/lnInclude/ -iquote. -IlnInclude -I/usr/lib/openfoam/openfoam2206/src/OpenFOAM/lnInclude -I/usr/lib/openfoam/openfoam2206/src/OSspecific/POSIX/lnInclude   -fPIC -c funkyPythonPostproc.C -o Make/linux64GccDPInt32Opt/funkyPythonPostproc.o
2022-09-19T08:46:43.4673450Z     default: funkyPythonPostproc.C:41:10: fatal error: pythonInterpreterWrapper.H: No such file or directory
2022-09-19T08:46:43.4678570Z     default:    41 | #include "pythonInterpreterWrapper.H"
2022-09-19T08:46:43.4682970Z     default:       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
2022-09-19T08:46:43.4683480Z     default: compilation terminated.
2022-09-19T08:46:43.4704170Z     default: make: *** [/usr/lib/openfoam/openfoam2206/wmake/rules/General/transform:35: Make/linux64GccDPInt32Opt/funkyPythonPostproc.o] Error 1

Here are the full logs (GitHub Actions auto-cleans after some time): logs_25.zip

I have not yet checked if all the files we need are still compiled.

@MakisH MakisH marked this pull request as draft November 14, 2022 12:13
@MakisH MakisH marked this pull request as ready for review November 14, 2022 12:13
@MakisH MakisH marked this pull request as draft November 15, 2022 15:36
@MakisH MakisH marked this pull request as ready for review November 15, 2022 15:37
@MakisH MakisH changed the base branch from main to develop November 18, 2022 14:00
@MakisH MakisH requested a review from fsimonis November 18, 2022 14:07
@MakisH

MakisH commented Nov 18, 2022

Copy link
Copy Markdown
Member Author

@fsimonis Can I get a code review? I have already tested that the changes work. The most cumbersome part was producing the new binaries for swak4Foam and then switching to them.

@MakisH MakisH merged commit ffd718c into develop Nov 18, 2022
@MakisH MakisH deleted the openfoam-v2206 branch November 18, 2022 14:18
MakisH added a commit that referenced this pull request Nov 18, 2022
@MakisH
Upgrade OpenFOAM to v2206 (#46)
94c5979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fsimonis fsimonis fsimonis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MakisH @fsimonis