Conversation
|
Looking at the code, it looks good. Thanks for directly contributing!
I usually don't do that here, since the build time of the VM is already quite long. It is not meant as an environment for the system tests. However, if you think this is ready, you can trigger a build of the VM and try it yourself. You can trigger that by converting the PR to draft and then marking it ready for review (or directly from the Actions menu, at least after the first time). |
|
Building currently seems to fail at downloading code-aster (unrelated), due to an SSL certificate issue. I will check again when we actually need to release the VM and potentially work around it. |
MakisH
left a comment
There was a problem hiding this comment.
Building the vm now also worked, so we can already merge this, unless you still want to try something additional.
* Add ASTE recipe for the latest ASTE release * Add corresponding aste version * Use branch name instead of version Co-authored-by: Gerasimos Chourdakis <makishourdakis@gmail.com>
* Add ASTE recipe for the latest ASTE release * Add corresponding aste version * Use branch name instead of version Co-authored-by: Gerasimos Chourdakis <makishourdakis@gmail.com>
... we could also test the validity of the installation by running
ctest. Do you usually do this during the installation?