Repository navigation
Remove the now-redundant comments #302
Description
Activity
Some regexes that help find many instances of redundant comments:
git grep -P '^\t(ld [abcdehl],|call( n?[zc],)?|j[pr]( n?[zc],)?|cp) [A-Z][A-Za-z0-9_]+ ; 'git grep -P '^\tldh? a, \[[whv][A-Z].+\] ; 'git grep -P '^\t(bit|res|set) [A-Z][A-Za-z0-9_]+, \S+ ; '
(Those turn up hundreds of lines, and many of them are false positives, useful comments that we should keep or maybe reword or occasionally turn into
ASSERTs.)
Many lines have comments that are trivial if you know the basics of GBZ80 assembly. Some also appear to have been added before functions and variables had meaningful labels. For example:
ldh [hMapROMBank], a ; save map ROM bankcall PrintStatusAilment ; print status conditionSome will also be redundant once we add more labels and constants. For example,
bit 0, a ; was the A button pressed?should bebit BIT_A_BUTTON, a.