Fix #4509 - Editable dropdown doesn't open when typing on a mobile de… #4878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mobile device
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
melloware
suggested changes
Dec 2, 2023
components/lib/dropdown/Dropdown.vue
Outdated
| onKeyDown(event) { | ||
| if (this.disabled) { | ||
| // Android keyboard event | ||
| const isAndroidKeyboardEvent = event.isComposing || event.keyCode === 229; |
Member
There was a problem hiding this comment.
You can use DomHandler.isAndroid() instead
There was a problem hiding this comment.
@melloware
if use DomHandler.isAndroid(), Android's backspace key will not work
He should mean to distinguish between normal keys and input methods like Chinese and Japanese
Author
|
I've refactored the code as per your suggestion, @melloware , Thank you for your recommendation, and I've tested the changes accordingly. |
Author
|
@tugcekucukoglu could you please review my PR? Thanks |
tugcekucukoglu
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4509 has been verified on both Android and iOS devices.