Evaluation display #45
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I've been trying out CoqGym for the last couple of days, and I really like it 😄.
Two minor issues have come up:
When installing, unzipping and making the project there are a bunch of files not in .gitignore, that I assume should not be pushed to Github. Maybe these could be added to .gitignore?
When evaluating a model (I have only tried with 'trivial' so far), the display.py script seemed to miss a loop over all proofs in a given theory/proof library. It assumed a single proof, when
rinfor r in results:was in fact a list of proofs (all the proofs in the current theory/proof library). Is this intentional? In any case, adding an inner loop fixed the problem for me (and the result was 2.44% correct proofs, which should be the case according to the paper 😃).