docs(WIP): Update AWS Guide with notes on Proxy and Perf #238
Conversation
There was a problem hiding this comment.
Hello @akundla-google, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the AWS guide to include information about the differences between AWS Nitro Enclaves and GCP Confidential Compute Spaces. It explains how the AWS approach requires a TCP-to-VSOCK proxy, which affects server performance. The changes recommend that AdTechs refer to the AWS-specific performance guide for recommendations on sizing machines and allocating resources.
Highlights
- AWS vs GCP: Explains the architectural differences between AWS Nitro Enclaves and GCP Confidential Compute Spaces.
- TCP-to-VSOCK proxy: Details the necessity and impact of the TCP-to-VSOCK proxy on AWS.
- Performance considerations: Highlights the networking performance differences between AWS and GCP, particularly for frontend services, and recommends consulting the AWS performance guide.
Changelog
- bidding_auction_services_aws_guide.md
- Added a section comparing AWS and GCP, focusing on the differences in their confidential computing architectures.
- Explained the need for a TCP-to-VSOCK proxy in AWS due to Nitro Enclaves.
- Discussed the performance implications of the proxy, especially for frontend services.
- Recommended consulting the AWS performance guide for sizing and resource allocation.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
In AWS's enclave deep,
A proxy's watch, secrets to keep.
Performance may wane,
But knowledge will reign,
As guides help AdTechs to sleep.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request updates the AWS guide with notes on proxy and performance considerations when using AWS Nitro Enclaves for Bidding and Auction services. The changes provide valuable insights into the architectural differences between AWS and GCP and their impact on server performance. Overall, the changes are well-written and informative.
Summary of Findings
- TODO link: The [TODO: link to AWS performance dialing-in guide section here] should be replaced with an actual link to the relevant section in the AWS performance guide.
Merge Readiness
The pull request provides useful information regarding the performance differences between AWS and GCP for Bidding and Auction services. However, the missing link to the AWS-specific performance dialing-in guide should be addressed before merging. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging.
e0cd5e6 to
fcdb177
Compare
Discusses how the root of the differences between AWS and GCP is the difference between AWS Nitro Enclaves and GCP Confidential Compute Spaces, how this requires the AWS TCP-to-VSOCK proxy, and that (and how) this affects server performance. Also updates the self-serve guide to include our scaling recommendations for each service, and AWS-specific enclave CPU allocation recommendations.
fcdb177 to
a329d37
Compare
Discusses how the root of the differences between AWS and GCP is the difference between AWS Nitro Enclaves and GCP Confidential Compute Spaces, how this requires the AWS TCP-to-VSOCK proxy, and that (and how) this affects server performance.