feat(om2): add native histograms to OpenMetrics2.0 #2634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
commented
Apr 30, 2025
|
|
||
| Numbers MUST be either floating points or integers. Note that ingestors of the format MAY only support float64. The non-real values NaN, +Inf and -Inf MUST be supported. NaN MUST NOT be considered a missing value, but it MAY be used to signal a division by zero. | ||
|
|
||
| Complex data types MUST contain all information necessary to recreate a Metric Type, with the exception of Created time and Exemplars. |
Member
Author
There was a problem hiding this comment.
This assume we'll have the created timestamp separate from the JSON like data. prometheus/OpenMetrics#285
Member
Author
|
Note self: add details how summaries and classic histograms one liners (so not NHCB spans/deltas) fit into it. |
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
ArthurSens
reviewed
May 24, 2025
Member
ArthurSens
left a comment
There was a problem hiding this comment.
Had some minutes to read the PR. Couldn't read everything though, I'll do a more complete review another day!
Reviewed from mobile
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
This comment was marked as outdated.
This comment was marked as outdated.
krajorama
commented
Jun 3, 2025
I did not want to clutter the examples with adding "# EOF" to all, so I made a new marker to explicitly add it on request. There was only one faulty example where we had an extra space, see the Exemplars section. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Allow multiple exemplars for complex types, i.e. native histograms. But require that the timestamp is present. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
c16426b to
7965787
Compare
beorn7
requested changes
Jun 12, 2025
Member
beorn7
left a comment
There was a problem hiding this comment.
Thanks for doing all of this.
Mostly commented about the histogram aspect (but I couldn't resist and referred to OM specific things now and then).
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
as we have buckets where we can count such measurements, as opposed to NaN. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
It will handled on float vs complex type sample level. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
bwplotka
reviewed
Dec 3, 2025
Member
bwplotka
left a comment
There was a problem hiding this comment.
Amazing!
Looks good, just some suggestions for tighter language 💪🏽
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
commented
Dec 3, 2025
krajorama
commented
Dec 3, 2025
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
commented
Dec 3, 2025
Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>
krajorama
commented
Dec 3, 2025
Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>
dashpole
reviewed
Dec 3, 2025
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Co-authored-by: David Ashpole <dashpole@google.com> Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Co-authored-by: David Ashpole <dashpole@google.com> Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
dashpole
approved these changes
Dec 5, 2025
bwplotka
approved these changes
Dec 10, 2025
Member
bwplotka
left a comment
There was a problem hiding this comment.
Epic work, let's go! 💪🏽
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Based on https://github.com/prometheus/proposals/blob/main/proposals/2024-01-29_native_histograms_text_format.md
And OpenMetrics 2.0 WG discussions.
Changes
Require that exemplars for complex type values have the timestamp.(1)Be permissive about the existence of _sum and _count series for classic histograms - for backwards compatibility.(1) Not doing this on account of being an implementation limitation and also contradicts having backwards compatibility when exposing classic histograms as complex type.
Out of scope
Open questions / decisions
See OpenMetrics2.0 WG meeting notes tab