Skip to content

Building from .zip should be possible #609

Closed
#806
#707
Closed
Building from .zip should be possible#609
#806
#707

Description

@quinox
quinox
opened on Mar 21, 2015

Currently you cannot build Prometheus using the zip-files mentioned in fe. https://github.com/prometheus/prometheus/releases/tag/0.12.0.

When you try you get a bunch of warnings such as fatal: Not a git repository (or any parent up to mount point /tmp) eventually followed by the usage output of 6l and the failure Makefile:30: recipe for target 'build' failed.

Relevant chat on IRC:

jrv | ah, the zip file doesn't work because the Makefile expects the source directory to still be a git repository.
jrv | GitHub creates those zip files automatically, so we never tried that.
jrv | "-X main.buildRevision" isn't followed by an argument for that reason, which is why ld6 crashes
jrv | cause that's built via a git command
jrv | VERSION=$(shell cat git rev-parse --show-toplevel/VERSION)

Activity

  1. abraithwaite commented on May 20, 2015

    @abraithwaite
    abraithwaite
    on May 20, 2015
    Contributor

    Is there any reason this version can't be in the Makefile?

    It'd be nice to build it from an archive which have predictable stable urls.

  2. juliusv
    closed this as completedin #707on May 20, 2015

  3. matthiasr commented on May 20, 2015

    @matthiasr
    matthiasr
    on May 20, 2015
    Contributor

    Reopening, as discussed in #707 this is not really fixed yet.

    As a workaround, set the VERSION variable either as VERSION=something make or make VERSION=something. After #707, both do the same.

  4. matthiasr
    reopened this on May 20, 2015
  5. juliusv
    closed this as completedin #806on Jun 15, 2015

  6. lock commented on Mar 24, 2019

    @lock
    lockbot
    on Mar 24, 2019

    This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

  7. lock
    locked and limited conversation to collaborators on Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions