Update go.mod dependencies before release #5883
Conversation
Signed-off-by: Julius Volz <julius.volz@gmail.com>
bwplotka
left a comment
There was a problem hiding this comment.
That looks quite scary as any of those dep updates can introduce pile of bugs, especially if we don't go through any changelog for those.
But if the idea is to always get latest on all deps before each release.. LGTM 👍
cmd/promtool/main.go
Outdated
| api := v1.NewAPI(c) | ||
| ctx, cancel := context.WithTimeout(context.Background(), 2*time.Minute) | ||
| val, err := api.LabelValues(ctx, name) | ||
| // TODO: Show warnings (second return value) somehow? |
There was a problem hiding this comment.
Can we add an issue for this? Otherwise, it will get lost.
There was a problem hiding this comment.
Created #5885 and added to comment here.
Now still have to figure out why a logger is nil in web tests...
Signed-off-by: Julius Volz <julius.volz@gmail.com>
It produced errors when marshaling Point values with special float values. Signed-off-by: Julius Volz <julius.volz@gmail.com>
|
Reverted json-iterator version, hoping this will fix CI. |
Signed-off-by: Julius Volz <julius.volz@gmail.com>
Signed-off-by: Julius Volz <julius.volz@gmail.com>
|
I had push a number of followup fix commits to deal with fallout from various behavioral changes... please take another quick look. |
bwplotka
left a comment
There was a problem hiding this comment.
Looks sane to me! 👍 Ship it!
Signed-off-by: Julius Volz julius.volz@gmail.com