Add postgres as a db#59
Merged
Merged
Conversation
added 2 commits
November 17, 2022 14:51
Signed-off-by: Evgeny Kuzin <evgeny@hudson-trading.com>
juliusv
reviewed
Nov 17, 2022
Member
juliusv
left a comment
There was a problem hiding this comment.
Awesome, thank you! Would you be ok with helping to look at any issues that users report with Postgres in the near future, if we add this?
Contributor
Author
Would be glad to :) |
Signed-off-by: Evgeny Kuzin <evgeny@hudson-trading.com>
Signed-off-by: Evgeny Kuzin <evgeny@hudson-trading.com>
Member
|
👍 Wonderful, thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github.com/lib/pqis in maintenance mode, but it seems like the best candidate still because we don't need all these fancy features that pgx provides and its fits as a database/sql Interface. Basically, I chose it based on this