feat: support unversioned requests #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Yonan <mario.yonan@procore.com>
dannyporrello
approved these changes
Apr 16, 2025
m-graf
previously approved these changes
Apr 16, 2025
m-graf
reviewed
Apr 17, 2025
Contributor
m-graf
left a comment
There was a problem hiding this comment.
We should update the changelog as well- code looks fine though!
njbbaer
previously approved these changes
Apr 17, 2025
tedyangx
previously approved these changes
Apr 18, 2025
…t support Signed-off-by: Mario Yonan <mario.yonan@procore.com>
af1ed12 to
d599745
Compare
njbbaer
reviewed
Apr 21, 2025
Signed-off-by: Mario Yonan <mario.yonan@procore.com>
njbbaer
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
This pull request introduces support for "unversioned" API requests, allowing users to make requests without specifying an API version. The changes include updates to documentation, the client implementation, and tests to accommodate this new feature.
Feature: Support for "unversioned" API requests
Documentation updates:
CHANGELOG.mdto document the new "unversioned" API request feature.README.mdwith an example of using theversion: 'unversioned'option in API requests.Client implementation:
urlConfigmethod inlib/client.tsto construct URLs without a version prefix whenversion: 'unversioned'is specified.versionmethod inlib/client.tsto return an empty string for "unversioned" requests.Testing:
test/client.spec.tsto verify that "unversioned" API requests function correctly.