Skip to content

Conversation

@rebelzach
Copy link
Member

This pull request:

  • Replaces the include tag in liquid.patch.js to conform to the Jekyll include style, it borrows heavily from the jekyll implementation here
  • Performs liquid parse before markdown is processed, helps avoid the liquid tags from getting 👊 💥
  • Updates the liquid.js file to most current implementation. There didn't seem to be many changes other than an update to cbSplit (Cross Browser Split)

If you want to see a cute example of this working, drive this PR to this link:
http://localhost:8000/#kingdom-building-ministries/kingdom-building-ministries-site/edit/test-prose/blog/_posts/2013-12-17-christmas-puppy.md

@mikemorris
Copy link
Contributor

@rebelzach Not sure what's wrong, but I'm not seeing a picture of a puppy =(

👍 to this change if you can get it working though.

Change from [content > markdown parse > liquid parse] to [content > liquid parse > markdown parse] because markdown likes to clobber quotes and adds autolinks to urls.
rebelzach added a commit that referenced this pull request Apr 22, 2014
Implement Jekyll style includes
@rebelzach rebelzach merged commit 30749a6 into prose:master Apr 22, 2014
@rebelzach rebelzach deleted the fix-include branch April 22, 2014 04:09
@parkr
Copy link
Contributor

parkr commented Apr 22, 2014

✨ 🎊 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants