-
Notifications
You must be signed in to change notification settings - Fork 722
Add StatusNotifier widget #2750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There is a lot of code here for supporting menus, when menus are ultimately not supported. How much of that needs to be in libqtile? Ideally we'd have a version that is similar to the |
|
Add for the menu stuff. I'll take another look and see if we can strip it out and find a simple way to hook it back in without significant rewrites. |
|
Also - where does the XML originally come from? I guess you didn't type it out :p |
|
Can't remember. Some Google search. No, didn't type it but could have also dumped it from an introspection call. |
|
Is that introspection call possible during runtime? I guess it's very unlikely, but could that interface change? |
|
Yes, it's possible at runtime. I avoided it as this is meant to be a standard (although the code is already catering for non-standard icons) |
|
Do you know how I could get that xml myself via introspection? Just interested in how this works - my dbus is lacking. |
|
I'm flipping this in to draft as I may make some changes as I'm working on the menu version in qtile-extras in parallel. |
9ee9d41 to
d213dfe
Compare
|
This should be good now. I've got menus working in my repo with not too much additional code required to hook it into this one. |
d213dfe to
d4513fc
Compare
|
Any updates on this? I'm in the process of switching to Wayland and would like to use qtile -- if this won't be done in the next week is there a guide for setting up waybar with qtile? |
waybar (and other bars) should work out of the box as you'd expect, so please post an issue if you do come across any issues with doing so! @elParaguayo can comment on the widget. |
My understanding is that won't do things like show workspaces and layouts? Perhaps I'm mistaken. |
|
Given that we've carved out the the context menus, this should be done and, ideally, just need testing by volunteers. Once it's committed, I'll push the context menus to my repo. |
Do you have an ETA on those context menus? I don't poke at tray icons too much but I don't want to run into a situation where I'm screwed without the menus. |
I don't think third party bars would display desktops in any wayland compositor as there isn't (yet?) a standard way to communicate "virtual desktops" as X11 knows them. Interesting point that I hadn't considered. There is a protocol for third party tools to control (i.e. close, focus) windows but that isn't implemented yet in Qtile. This is definitely on my list so it's good to have some reinforcement that there is demand for such tools. |
Perhaps something that works similar to swaymsg? I'm not too involved in the development but having a protocol with some of the same abilities as swaymsg or even EWMH would be extremely useful. E: Regardless, that isn't really a discussion for this PR lol. Perhaps set up a tracking issue or other method of conversation? |
Ah yes - you can use Qtile's IPC for this, if the bar can execute arbitrary commands for things. See: http://docs.qtile.org/en/latest/manual/commands/shell/qtile-cmd.html
Feel free to open an issue or discussion, or chat on IRC :) |
|
This is working great! I remember asking this before but I can't find it, and maybe things have changed, but is it possible to load the data in |
|
Ah, yeah. We were going to replace it with the introspection call. I can do that. |
@judemille Sorry. Missed this. In short, the code for the context menus is pretty much all done. It was originally part of this PR but we cut it back as it adds too much extra code to the codebase. The additional code and the full StatusNotifier widget will be available from my 'qtile-extras' repo. I'd be very surprised if the menus provide any functionality that's not available from the app itself. The menus should really just be there for convenience. |
d21cce9 to
a14eff9
Compare
|
Schema stuff has been removed. Fixed the docs. NB this PR also adds the widget to the default config but maybe we should think about that a bit. |
a14eff9 to
e734750
Compare
Add a widget implementing the StatusNotifierItem specification. Should work on both x11 and Wayland backends. NB Currently, the widget does not implement context menus for the icons.
e734750 to
e8caefb
Compare
|
Added changelog entry and removed from This should be good to merge now. |
|
Beautiful! Thanks for working on this! |
Add a widget implementing the StatusNotifierItem specification. Should work on both x11 and Wayland backends.
NB Currently, the widget does not implement context menus for the icons.
This replaces #2601. The only difference is that context menu support has been removed/disabled so as not to include popup toolkit in main codebase. I can host on my
qtile-extrasrepo.NB - I've left in the underlying methods to generate the menus from DBus. However, the widget does not access these and there is not code to turn a
DBusMenuIteminto a visible menu.