Skip to content

Conversation

@richcarni
Copy link
Contributor

Fix // clandg-format on directive so clang-format formats remainder of file

@tych0
Copy link
Member

tych0 commented Dec 18, 2025

Can we enforce clang-format as part of CI?

@richcarni
Copy link
Contributor Author

richcarni commented Dec 18, 2025

Can we enforce clang-format as part of CI?

Do you mean clang-tidy? Actually I think my commit message isn't very clear

@tych0
Copy link
Member

tych0 commented Dec 18, 2025

I mean whatever autoformatter generated this diff 😃

@richcarni
Copy link
Contributor Author

richcarni commented Dec 18, 2025

clang-format is part of CI, unless you explicitly disable it for blocks of code within

// clang-format off

// clang-format on

The issue in util.c was a missing space between the // and clang-format on. So it wasn't turning back on for the rest of the file

*Updated commit message

A space required between `//` and `clang-format on` for this
directive to re-enable clang-format

With this fixed, clang-format now formats the rest of the file
@tych0
Copy link
Member

tych0 commented Dec 18, 2025

I see, ok, thanks!

@tych0 tych0 merged commit 46a156a into qtile:master Dec 18, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants