Silence unhelpful log when object not found for self #3076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During long-running debug sessions my log fills up with `No object found for process 0`. I'm fairly confident that GetEventParameter(... kEventParamProcessID) returning PSN of 0 refers to the current process (though having trouble finding this in official Apple documentation). This silences this log spam when running in debug mode.
Member
|
LGTM. The error is actually a higher level problem (I think) with the fact that we now can no longer get info on the process because it's already been killed (I think the 'old' way of doing things with the carbon API meant we could still get the info). But if processes are working, then this is all good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During long-running debug sessions my log fills up with
No object found for process 0.I'm fairly confident that GetEventParameter(... kEventParamProcessID)
returning PSN of 0 refers to the current process (though having trouble
finding this in official Apple documentation).
This silences this log spam when running in debug mode.
Alternatively could map
0to the Quicksilver PID when scanning for runningprocesses, but that would add a little overhead every time processes were
scanned and might be problematic if someone had multiple QS processes running
(for whatever reason).