Skip to content

Conversation

@braised-babbage
Copy link
Contributor

@braised-babbage braised-babbage commented Nov 14, 2019

This is mostly a sanity check.

@braised-babbage braised-babbage requested a review from a team as a code owner November 14, 2019 00:06
@karalekas
Copy link
Contributor

@kilimanjaro why is it succeeding?

@karalekas
Copy link
Contributor

also @notmgsk made the PR: #214

(flet ((eval-prog (quil-string)
(let ((qvm (make-qvm 2)))
(load-program qvm (with-output-to-quil
quil-string))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parse-quil and kill newline

@notmgsk
Copy link
Member

notmgsk commented Nov 14, 2019

@kilimanjaro why is it succeeding?

Are the tests pulling master? I forget how we set that up.

@karalekas
Copy link
Contributor

karalekas commented Nov 14, 2019

@notmgsk https://gitlab.com/rigetti/forest/qvm/-/jobs/350247291 this job uses cl-quil/quilc 1.12.0 and it worked. we pull edge (read: master) in the edge-tagged tests

@notmgsk
Copy link
Member

notmgsk commented Nov 14, 2019

@notmgsk https://gitlab.com/rigetti/forest/qvm/-/jobs/350247291 this job uses quilc 1.12.0 and it worked

Puzzling

Copy link
Member

@stylewarning stylewarning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mark's suggestion

@karalekas
Copy link
Contributor

@kilimanjaro did we figure out why it was succeeding before?

@braised-babbage
Copy link
Contributor Author

@kilimanjaro did we figure out why it was succeeding before?

Not I

@stylewarning stylewarning merged commit c7d1b15 into master Nov 19, 2019
@stylewarning stylewarning deleted the feature/add-xy-test branch November 19, 2019 20:45
@notmgsk notmgsk mentioned this pull request Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants