Support hhvm 4.69+ #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@tyronjung-quizlet Travis is not picking up PRs for testing. |
Adds hhconfig directives required for hhvm 4.62. These directives are only needed when hammock is the main project. If you use hammock as a dependency, you don't need this fix. Fixes parse error in hhvm 4.68 for array<mixed>.
Contributor
|
Hm weird, not sure why Travis isn't running... |
tyronjung-quizlet
approved these changes
Aug 17, 2020
Contributor
tyronjung-quizlet
left a comment
There was a problem hiding this comment.
Thanks for doing this! Travis isn't running but this change should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hhvm 4.62 introduced the requirements for whitelisting your hh_fixmes.
This didn't break for dependents, only when hammock is typechecked in isolation.
Hhvm 4.68 removed the
array<_>andarray<_, _>typehints.Use
varray<_>anddarray<_, _>instead for maximum compatibility.HEADS-UP: In older hhvm versions, (d/v)arrayness was not checked at runtime and never versions will error on typehint mismatches.