Edit Dockerfile from debian to buster#51
Conversation
ahmedre
left a comment
There was a problem hiding this comment.
jazakumAllah khairan! 2 minor comments
| @@ -1,4 +1,4 @@ | |||
| FROM debian:jessie | |||
| FROM debian:buster | |||
There was a problem hiding this comment.
how about debian:buster-slim instead?
| make && \ | ||
| make install | ||
|
|
||
| RUN find /app -type f -name '*.pl' -exec sed -i 's/\r$//' {} \; |
There was a problem hiding this comment.
can we change the script/generate.pl directly just remove the \r instead of running this every time?
There was a problem hiding this comment.
actually not seeing a \r here - i'll look into this some more.
|
jazakumAllah khairan for the PR - I merged #50, which had some of these changes along with bumping mysql. it's working for me now on macOS. where did you find this \r fix is needed since things are ok for me without it? |
|
Assalamou aleikoum sorry for the response time, I didn't receive the notifications...
May Allah agree our deeds |
|
wa3laikum alsalam, |
|
Just tried, the build is OK but I have a new error on the main branch, maybe the doc. is not updated : λ docker-compose run gen /app/script/generate.pl --width 1300 --output ./output/ --pages 50
Shall I open a new issue ? |
Made two moidifications to make it working, as discussed in the following issue : #49
The image is now working fine al hamdouliLlah