Skip to content

Conversation

@akberenz
Copy link
Member

Fix to scaling interpolation for #704

Looks like a mistake/lost line from a rebase? As the history timeline around this commit is weird.
I didn't see any ill effects to rasterized HTML re-adding this line in, though it would probably be a good idea to test around that as well, since the linked commit was for adding that capability in.

@tresf
Copy link
Contributor

tresf commented Sep 11, 2020

I didn't see any ill effects to rasterized HTML re-adding this line in, though it would probably be a good idea to test around that as well, since the linked commit was for adding that capability in.

I think because parseData, the function where the fix lands is overridden.

@Override
public void parseData(JSONArray printData, PrintOptions options) throws JSONException, UnsupportedOperationException {
try {

This is safe to merge because it won't affect HTML.

@tresf tresf merged commit 3c97f89 into master Sep 11, 2020
@tresf tresf deleted the scaling-nn branch September 11, 2020 15:23
emkah4 pushed a commit to Fourbolts/orderkrab-tray that referenced this pull request May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants