Make comparison results deterministic in the UI#1654
Merged
Conversation
Contributor
Author
|
The remaining CI issues seem unrelated to my PR. |
SpeedyGX
pushed a commit
to SpeedyGX/czkawka
that referenced
this pull request
Apr 29, 2026
* IndexMap * Put back std::fs but only for unix * Revert change in localizer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo (left is release version, right is the one built from this branch):
screen-capture.mp4
Fixes #1652.
The issue was that the code uses the standard HashMap in a lot of places, which infamously has randomised iteration order as a protection from DoS attacks on servers.
These concerns don't apply to local apps, and the randomisation leaks into comparisons and the UI.
To fix it, I've switched all the usages of HashMap and HashSet in czkawka_core to the indexmap crate, which is intended exactly for this kind of scenarios - when you want the performance of the HashMap, but care about deterministic iteration.