Gridstore non-blocking flush#8188
Merged
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
timvisee
reviewed
Feb 20, 2026
timvisee
left a comment
Member
There was a problem hiding this comment.
I really like that we utilize the existing flushers here, keeping these changes relatively minimal.
Could you share some benchmarks results for this one.
| /// | ||
| /// Best suited for random reads. | ||
| mmap: MmapMut, | ||
| mmap: MmapSlice<u8>, |
Member
There was a problem hiding this comment.
Why swap the type here? Is it just so that we have a premade .flusher()?
Member
There was a problem hiding this comment.
I think this is fine, we are going to change this to universal file interface anyway
Contributor
Author
There was a problem hiding this comment.
Because MmapSlice has a ready-to-use flusher(). MmapMut is an external crate type without flusher.
Member
|
Thanks! I like this a lot better |
timvisee
approved these changes
Feb 23, 2026
generall
pushed a commit
that referenced
this pull request
Mar 26, 2026
* gridstore unblocked flush * review remarks
KShivendu
pushed a commit
that referenced
this pull request
Mar 30, 2026
* gridstore unblocked flush * review remarks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes search spikes while intensive upsert-search on low-IO configuration.
Spike appears when gridstore flush blocks writing by
RwLock::read. Writing blocks searches - spike appears because of waiting of flush.The solution is non-blocking flush, where flush does not block writes.
To achieve it, this PR changes
MmapMutintoMmapSlice<u8>which can be created fromMmapMutand hasFlushersupport.