fix(segment): guard min_should estimator edge cases#8217
Merged
Conversation
9 tasks
4af12b0 to
4f6ea95
Compare
coszio
reviewed
Feb 24, 2026
4f6ea95 to
9778d47
Compare
9778d47 to
c6fdec4
Compare
generall
approved these changes
Feb 25, 2026
generall
pushed a commit
that referenced
this pull request
Mar 26, 2026
Co-authored-by: local-user <local-user@local>
KShivendu
pushed a commit
that referenced
this pull request
Mar 30, 2026
Co-authored-by: local-user <local-user@local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7974
Summary
This PR prevents a panic (
alloc::raw_vec::capacity_overflow) insegment::index::query_estimator::combine_min_should_estimationswhenmin_should.min_countis an edge value.What changed
combine_min_should_estimations:min_count == 0→CardinalityEstimation::exact(total)(trivially satisfied)min_count > estimations.len()→CardinalityEstimation::exact(0)(unsatisfiable)Why
Without these guards, malformed/edge inputs can reach
combinations(min_count)andtrigger pathological allocation, leading to a server panic instead of a safe estimate.
Local verification
cargo test -p segment✅All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --workspace --all-featurescommand?Changes to Core Features: