Fix OOB heap read crash with malicious snapshot#9268
Merged
Conversation
IvanPleshkov
approved these changes
Jun 3, 2026
timvisee
added a commit
that referenced
this pull request
Jun 3, 2026
* Validate quantized u8 data size on load * Validate other quantization types * Add test * Use fs_err
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes BBP-827.
Fixes out of bound heap read with a malicious snapshot. A snapshot could configure a different quantized vector length than what is actually stored. After loading the collection from such recovered snapshot, Qdrant may read out of bound.
This fixes the issue by enforcing a correct configured length (compared to storage) when loading quantized storage. If the configured length is not correct, an error is reported.
All Submissions:
devbranch (notmaster) and my branch was created fromdev.Changes to Core Features: