Issue #155: Sanitiser issues#165
Conversation
This patch ports the patch to Qhull in the R geometry library davidcsterratt/geometry@5270d36 to fix sanitiser issues that were identified by Brian Ripley of the R team and fixed with the help of Tomas Kalibera.
|
Please change the SETbasesize document to The same changes are needed for the non-relocatable builds (libqhull.h etc.) Are any changes needed for the C++ interface to Qhull or the Qhull test programs (user_eg.c, etc.)? Please change CMakeLists to enforce c99 as the minimum build version. Are there additional caveats about changing the minimum C version (perhaps the use of the -ansi switch). The same restriction needs to be made for the DevStudio builds, Qt Creator builds, Makefile builds, and simplified builds. [https://github.com/qhull/qhull/wiki/Qhull%20build%20systems](Qhull's build systems) Please report the build tests and code tests made for this change. It modifies the declaration of the core data structure for Qhull. Should this change be delayed to a full release of Qhull (hopefully Qhull 2026.1)? It is likely to break someone's code or build. Users of the github alpha labels have likely moved to modern C. It may be a good idea to start the move now instead of later. The next full release should modernize Qhull's C and C++ code and simplify its build products. It should include memory-efficient 64-bit code and a Lua scripting interface, but these improvements may be delayed to a later release. |
|
For the next release of Qhull. This change appears to be too much for an alpha release. |
This patch ports the patch to Qhull in the R geometry library davidcsterratt/geometry@5270d36 to fix sanitiser issues that were identified by Brian Ripley of the R team and fixed with the help of Tomas Kalibera.