Skip to content

fix(localshell): no output when using exec_command on Windows#34

Merged
qqqqqf-q merged 6 commits into
qqqqqf-q:mainfrom
SkyAerope:fix/windows-exec-command-output
May 6, 2026
Merged

fix(localshell): no output when using exec_command on Windows#34
qqqqqf-q merged 6 commits into
qqqqqf-q:mainfrom
SkyAerope:fix/windows-exec-command-output

Conversation

@SkyAerope

Copy link
Copy Markdown
Collaborator

修复Windows下模型使用exec_command工具成功却无输出的问题

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1ed8b3f5d7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/services/worker/internal/tools/localshell/controller.go Outdated
@SkyAerope

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 049f222fa7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/services/worker/internal/tools/localshell/output_decoder_windows.go Outdated
@SkyAerope SkyAerope force-pushed the fix/windows-exec-command-output branch from 77de866 to 62375b4 Compare May 6, 2026 09:21
@SkyAerope

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 62375b4565

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/services/worker/internal/tools/localshell/output_decoder_windows.go Outdated
@qqqqqf-q qqqqqf-q force-pushed the fix/windows-exec-command-output branch from 68378db to 95fb182 Compare May 6, 2026 14:11

@qqqqqf-q qqqqqf-q left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已复审:localshell 进程生命周期、Windows 环境变量保留、PTY 路径等问题已处理,未发现新的阻塞问题。

@qqqqqf-q qqqqqf-q merged commit cdcd392 into qqqqqf-q:main May 6, 2026
8 of 11 checks passed
@SkyAerope SkyAerope deleted the fix/windows-exec-command-output branch May 6, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants