Skip to content

feat: support mouse button 6&7#82

Merged
r-c-f merged 1 commit into
r-c-f:masterfrom
Sciroccogti:master
May 29, 2023
Merged

feat: support mouse button 6&7#82
r-c-f merged 1 commit into
r-c-f:masterfrom
Sciroccogti:master

Conversation

@Sciroccogti

Copy link
Copy Markdown
Contributor

For mouse like Logi MX master3, the two side buttons are Mouse button 6 and Mouse button 7.

This PR simply maps the two buttons to BTN_SIDE and BTN_EXTRA, and fix the issue that xwayland would crash when button 6 or 7 is clicked.

@r-c-f

r-c-f commented May 29, 2023

Copy link
Copy Markdown
Owner

I'm curious as to which server is actually sending this, as I've always had the extras mapped back to 4 and 5 instead, and I think they'd actually be dropped by input-leap. Out-of-range buttons should definitely be dropped here as well, but I'll do that in another commit and merge this, as -- while looking a bit weird to repeat the buttons in the default map -- it solves a problem, and can't really create one for anyone else.

Thank you for this and your other recent PR, by the way.

@r-c-f r-c-f merged commit 13ea71c into r-c-f:master May 29, 2023
@Sciroccogti

Copy link
Copy Markdown
Contributor Author

I'm using https://github.com/pwr-Solaar/Solaar for Logi mouse, but I think the key map is default for the side buttons.

Yes, the issue is actually introduced by the out-of-range buttons which were mapped to strange keycodes. So I also wonder whether more mouse buttons should be supported.

Thank you for your wonderful work and passion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants