Skip to content

Conversation

@raffscallion
Copy link
Contributor

Extended dbUnquoteIdentifier to support Id objects with a catalog attribute. This issue was identified in, and partially resolves, #175. dbWriteTable will now succeed in non-default schema as long as the catalog is specified.

@raffscallion
Copy link
Contributor Author

Hmm, I apologize. This is my first attempt at a pull request. I'm not sure how to interpret or pass that check, but I'll look into it.

@jimhester
Copy link
Contributor

The check is saying there were no tests which run the modified code, so you would have to write a test case for this to pass it, the best place to add it would be (I think) in https://github.com/r-dbi/DBI/blob/master/tests/testthat/test-quote.R

@raffscallion
Copy link
Contributor Author

Thanks, @jimhester. Tests are in - hope they're reasonable.

@krlmlr krlmlr merged commit 15632b4 into r-dbi:master Nov 26, 2018
@krlmlr
Copy link
Member

krlmlr commented Nov 26, 2018

Thanks!

@StigKorsnes
Copy link

Any updates on this?
When is next relase, and is this issue fixed in it? I guess I`m asking If I need to use alternatives, or a solution is at hand.
Was using dbWriteTable successfully with SQL 2016 and dbUnquoteIdentifier() with Id(catalog,schema,table) back in march.

Any help appreciated,
Stig

@krlmlr
Copy link
Member

krlmlr commented Dec 30, 2018

I'm planning a release round of DBI and related packages by end of February.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants