v1.5.0 release candidate#812
Merged
Merged
Conversation
``` ✖ Error: vignettes/develop.Rmd:25:181 404: Not Found Posit employees have access to the [Posit Professional drivers](https://docs.posit.co/pro-drivers/) and the infrastructure used to build and test them in the [rstudio/pro-drivers](https://github.com/rstudio/pro-drivers) repo. The Posit Professional drivers are a set of drivers vendored from Magnitude Simba that support many of the most popular DBMS, including SQL Server, Oracle, Redshift, Databricks, Snowflake, etc. The repository they're developed in contains tooling to spin up a number of databases in docker containers to test against. ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ✖ Error: vignettes/develop.Rmd:35:47 404: Not Found Among other things, the [rstudio/pro-drivers](https://github.com/rstudio/pro-drivers) repo defines a `MAKE` tool for setting up and tearing down databases in docker containers. Ensure that you have a docker daemon running (i.e. Docker Desktop open) and, if you're on macOS aarch64, have `Settings > Use Rosetta for x86_64/amd64 emulation on Apple Silicon` enabled. To start a container for a given `dbms`, run `MAKE dist=none DB=dbms up`, and **tear it down** with `MAKE dist=none DB=db down`. To see available `dbms` options, see the names of `.yml` files in the `docker-compose` directory. Find connection details for each database in `docker/shared/odbc.ini`. ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ✖ Error: vignettes/develop.Rmd:316:60 404: Not Found If you're a Posit employee, you should have access to the [https://github.com/rstudio/warehouse](https://github.com/rstudio/warehouse) repository. Follow the instructions there to get access to the internal Redshift cluster. Access to the cluster is only enabled through Posit's internal Workbench instance, where the professional drivers will already be installed. ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ✖ Error: README.md:22:10 403: Forbidden [Oracle](https://www.oracle.com/database), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ```
Member
|
Probably should be a minor release, I think. |
Collaborator
Author
|
You got it. Still needs the DESCRIPTION version bump to 1.5.0 when you submit. |
Member
|
And submitted 😄 |
Collaborator
Author
|
Seeing: Will try to see if I can reproduce / get some more information out of macbuilder. |
mac-builder appears to be down today (possibly as a result of CRAN being down earlier this morning?) and I'm [unable to replicate the failures on R-hub](https://github.com/r-hub2/indirect-dragonfly-odbc/actions/runs/9350831269). Will skip those tests on CRAN for this release.
Collaborator
Author
|
mac-builder appears to be down today (possibly as a result of CRAN being down earlier this morning?) and I'm unable to replicate the failures on R-hub. Suggesting that we skip those tests on CRAN for this release. EDIT: forgot to mention, those R-hub builds are with: test_that("set_odbcsysini() works (#791)", {
skip_if(is_windows())
# expect_false(identical(Sys.getenv("ODBCSYSINI"), ""))
path <- dirname(odbcListConfig()[["drivers"]])
Sys.setenv(ODBCSYSINI = path)
expect_equal(Sys.getenv("ODBCSYSINI"), path)
}) |
Member
|
Resubmitted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #811, closes #807. Two notes:
Depending on where the Snowflake migration is at, these may be the first GHA to fail. The offending tests use:
...so will not be an issue on CRAN.