You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
OK, looks like there's some version dependency problems where * is not supported. Would help to have some experts weigh in :)
For example, one approach would be to add a helper that compiles a trivial example to test for the feature. But maybe there's a simpler / already-known alternative.
I see this on the failing macos:
Apple LLVM version 15.0.0
Optimized build.
Default target: arm64-apple-darwin23.6.0
Host CPU: apple-m1
This on the failing windows:
gcov (x86_64-posix-seh, Built by MinGW-W64 project) 4.9.3
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or
FITNESS FOR A PARTICULAR PURPOSE.
And this on the passing linux:
gcov (Ubuntu 13.3.0-6ubuntu2~24.04) 13.3.0
Copyright (C) 2023 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
But that again is a bit of overkill -- requires refactoring how the gcov output is processed to involve aggregating from the (line, block) to the (line) level. I'm also not familiar enough with if there are other implications to work through.
For now, I'll orient on a has_partial_coverage() helper that we can aim to improve in the future, since the very small change "just works" for many users (and especially most default GHA runners).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #604.
Not well tested yet -- my machine is some sort of borked & I haven't had time to fix it.
Checking in now since I think it's already in a good place for at least high-level review.