Support passing non-standard extra blocks. #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables support for handling `{% nested_widget %}...{% endnested %}` blocks used by sniplates.
This creates an extra command-line argument (-b --extra-block), that can be supplied multiple times. Values like "nested_widget,endnested" are split into a tuple, and then passed as a list of tuples into the parser, which then prefers to use this for detecting an end tag, but falls back to the previous mechanism if the current tag does not have an explicit end-tag value.
Member
|
Thank you very much for this contribution, @schinckel ! I appreciate your solution of adding a command-line argument. It avoids the complexity of adding a configuration file and still makes it possible to tweak DjHTML's behavior through For context and reference, in #40, we discussed the possibility of adding a config file to ignore certain block tags. In #100, we solved a related problem where some end tags were not correctly recognized. I will merge this PR, add a section about command-line arguments to the README, release it, and of course credit you. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables support for handling
{% nested_widget %}...{% endnested %}blocks used by sniplates.This creates an extra command-line argument (-b --extra-block), that can be supplied multiple times. Values like "nested_widget,endnested" are split into a tuple, and then passed as a list of tuples into the parser, which then prefers to use this for detecting an end tag, but falls back to the previous mechanism if the current tag does not have an explicit end-tag value.