[codex] fix skip complete threads resume#694
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
resume -threads -skip-complete-threadsflow so historical direct thread resume items are not dropped before the skip predicate can evaluate them.The previous mitigation relied on discovering threads from channel history, which meant threads whose parent message was outside the channel lookback window could be missed. This change includes thread resume items again when
-threadsis enabled and applies the complete-thread skip check after the first directconversations.repliespage.Impact
Complete direct threads still avoid full pagination and database writes, while incomplete historical threads remain resumable even when their parent messages are outside
-lookback.Validation
go test ./stream ./cmd/slackdump/internal/resume ./internal/chunk/backend/dbase