Skip to content

Reduce binary size by removing regex #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 1 commit into from
Mar 25, 2022
Merged

Reduce binary size by removing regex #600

mergify merged 1 commit into from
Mar 25, 2022

Conversation

@redzic
Copy link
Collaborator

@redzic redzic commented Mar 25, 2022 •
edited
Loading

Decreases binary size by about 1.1 MB by avoiding regex as a transitive dependency.

  • Switch to git console-rs, which rewrote the ANSI parser without regex, making it faster, and also significantly decreasing the binary size
  • Also remove patch override of rav1e since av-scenechange already specifies a git version, so patching the version does not affect it

@mergify mergify bot merged commit d9d15a9 into rust-av:master Mar 25, 2022
@redzic redzic deleted the remove-regex branch March 25, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shssoichiro shssoichiro shssoichiro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@redzic @shssoichiro