Skip to content

Conversation

@weihanglo
Copy link
Member

What does this PR try to resolve?

This should be mentioned in changelog that not only cargo metadata
but any other JSON message emitted by Cargo would be affected.
The change was made intentionally so not considered a breaking change.

Fixes #13867

How should we test and review this PR?

Read the changelog?

Additional information

@rustbot
Copy link
Collaborator

rustbot commented May 8, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 8, 2024
@epage
Copy link
Contributor

epage commented May 8, 2024

@bors r+

@bors
Copy link
Contributor

bors commented May 8, 2024

📌 Commit b907805 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2024
@bors
Copy link
Contributor

bors commented May 8, 2024

⌛ Testing commit b907805 with merge de88d8e...

@bors
Copy link
Contributor

bors commented May 8, 2024

☀️ Test successful - checks-actions
Approved by: epage
Pushing de88d8e to master...

@bors bors merged commit de88d8e into rust-lang:master May 8, 2024
@weihanglo weihanglo deleted the changelog branch May 8, 2024 18:09
bors added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2024
Update cargo

7 commits in 0ca60e940821c311c9b25a6423b59ccdbcea218f..4de0094ac78743d2c8ff682489e35c8a7cafe8e4
2024-05-08 01:54:25 +0000 to 2024-05-09 16:09:22 +0000
- Fix docs for unstable script feature (rust-lang/cargo#13893)
- Refactor cargo lint tests (rust-lang/cargo#13880)
- test(rustfix): run some tests only on nightly (rust-lang/cargo#13890)
- Old syntax suggestion (rust-lang/cargo#13874)
- docs: clarify dash replacement rule in target name (rust-lang/cargo#13887)
- Add local-only build scripts example in check-cfg docs (rust-lang/cargo#13884)
- docs(changelog): also mention `--message-format=json` (rust-lang/cargo#13882)

r? ghost
@rustbot rustbot added this to the 1.80.0 milestone May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Breaking change to json-render-diagnostics target name in nightly

4 participants