Handle opening browser with opener crate
#5888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
Member
|
@bors: r+ Thanks for this @Seeker14491! |
Contributor
|
📌 Commit 48d0708 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Aug 15, 2018
Handle opening browser with `opener` crate Fixes #5701 A note about behavior on Linux: When looking for a browser to open the docs with, Cargo currently tries the `$BROWSER` environment variable, `xdg-open`, `gnome-open`, and finally `kde-open`, in that order. With this commit, this behavior changes; the `opener` crate always uses the `xdg-open` script, which is included in the `opener` crate. The `xdg-open` script takes care of finding a suitable browser.
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5701
A note about behavior on Linux:
When looking for a browser to open the docs with, Cargo currently tries the
$BROWSERenvironment variable,xdg-open,gnome-open, and finallykde-open, in that order. With this commit, this behavior changes; theopenercrate always uses thexdg-openscript, which is included in theopenercrate. Thexdg-openscript takes care of finding a suitable browser.