--all-targets fixes #6039
Merged
--all-targets fixes #6039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
☔ The latest upstream changes (presumably #6037) made this pull request unmergeable. Please resolve the merge conflicts. |
c213b48 to
ca6d7d7
Compare
- Fix: `cargo test --all-targets` was running lib tests three times. - `--all-targets` help strings were wrong or misleading. - Minor cleanup to add `Proposal` type to maybe make the code more readable.
ca6d7d7 to
3a1cad6
Compare
Member
|
@bors: r+ |
Contributor
|
📌 Commit 3a1cad6 has been approved by |
Contributor
|
⌛ Testing commit 3a1cad6 with merge f376fae872289410bb3cc5baa43dd35fc368c200... |
Contributor
|
💔 Test failed - status-appveyor |
Member
|
@bors: retry |
Contributor
bors
added a commit
that referenced
this pull request
Sep 18, 2018
--all-targets fixes - Fix: `cargo test --all-targets` was running lib tests three times. - `--all-targets` help strings were wrong or misleading. - Minor cleanup to add `Proposal` type to maybe make the code more readable. Closes #5178.
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo test --all-targetswas running lib tests three times.--all-targetshelp strings were wrong or misleading.Proposaltype to maybe make the code more readable.Closes #5178.