Never use templates when managing git repos #6252
Conversation
|
Sounds good to me. @bors: r+ |
|
📌 Commit a2b0611b2c40f4f8f6967ce9d1fdcd5120c05c06 has been approved by |
ehuss
left a comment
There was a problem hiding this comment.
Windows needs "C:/path/to/thing" style paths in gitconfig.
ehuss
left a comment
There was a problem hiding this comment.
Windows needs "C:/path/to/thing" style paths in gitconfig.
tests/testsuite/git.rs
Outdated
There was a problem hiding this comment.
| "#, git_project2.url().to_file_path().unwrap().display()).as_bytes(), | |
| "#, | |
| git_project2 | |
| .url() | |
| .to_file_path() | |
| .unwrap() | |
| .display() | |
| .to_string() | |
| .replace("\\", "/") | |
| ) | |
| .as_bytes(), |
|
I think I broke/confused github trying the new suggestion feature. Anyways, I was trying to say, the code needs to be changed to: For "C:/path/to/thing" for gitconfig style paths (double quotes and forward slashes). |
|
⌛ Testing commit a2b0611b2c40f4f8f6967ce9d1fdcd5120c05c06 with merge 8e6b81c41c088d3bca9a6a2ba59ade2c815aaa4f... |
|
💔 Test failed - status-appveyor |
This commit disables usage of git templates whenever Cargo manages repositories in its internal git database. Templates don't want to be used at all in these situations and have been known to cause usability bugs. Closes rust-lang#6240
a2b0611 to
2a4cdc6
Compare
|
@bors: r=dwijnand |
|
📌 Commit 2a4cdc6 has been approved by |
Never use templates when managing git repos This commit disables usage of git templates whenever Cargo manages repositories in its internal git database. Templates don't want to be used at all in these situations and have been known to cause usability bugs. Closes #6240
|
☀️ Test successful - status-appveyor, status-travis |
This commit disables usage of git templates whenever Cargo manages
repositories in its internal git database. Templates don't want to be
used at all in these situations and have been known to cause usability
bugs.
Closes #6240